[wrangler] Watch the entire module root + watch requirements.txt#5310
Merged
[wrangler] Watch the entire module root + watch requirements.txt#5310
Conversation
🦋 Changeset detectedLatest commit: 93f592b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5310 +/- ##
==========================================
+ Coverage 72.16% 72.22% +0.05%
==========================================
Files 317 317
Lines 16372 16372
Branches 4169 4169
==========================================
+ Hits 11815 11824 +9
+ Misses 4557 4548 -9 |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-wrangler-5310You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5310/npm-package-wrangler-5310Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-wrangler-5310 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-create-cloudflare-5310 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-cloudflare-kv-asset-handler-5310npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-miniflare-5310npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-cloudflare-pages-shared-5310npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-cloudflare-vitest-pool-workers-5310Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
petebacondarwin
requested changes
Mar 22, 2024
petebacondarwin
approved these changes
Mar 22, 2024
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
penalosa
force-pushed
the
penalosa/watch-requirements
branch
from
6602432 to
79c9cc2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
In
--no-bundlemode watch the entire module root for changes, rather than just the entrypoint file. Additionally, watch therequirements.txtfile for Python workers.Fixes EW-8223
Author has addressed the following